Avoid bashism in configure script #95
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
thanks, |
&> is non-standard for redirecting stdin and stderr. It is a short-hand copied from csh's >& by zsh and later bash. It is equivalent to >word 2>&1 which will also work in dash (/bin/sh on Debian) or other plain Bourne/POSIX shells. Signed-off-by: Oliver Kiddle <okiddle@yahoo.co.uk>
|
I've pushed a replacement commit with |
|
Thank you, yes github assumes the "standard" DCO as published by the Linux Kernel and we do the same. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the configure script is dumping a log message for the most recent commit into the middle of the output.
&> is non-standard for redirecting stdin and stderr. It is a short-hand copied from csh's >& by zsh and later bash. It is equivalent to >word 2>&1 which will also work in dash (/bin/sh on Debian) or other plain Bourne/POSIX shells.
I would perhaps question whether it might be better to check for the existence of a
.gitdirectory instead. Or for a git invocation that does less, perhaps rungit rev-parse --git-dir, though that still needs the redirection. Or drop the autoconf test and handle things within the Makefile. Many projects use other forms such asgit describe --tags --long --abbrev=7instead.